Add counters to Metric #784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franciscodr
reviewed
Sep 4, 2024
...opentelemetry/src/main/kotlin/com/xebia/functional/xef/opentelemetry/OpenTelemetryCounter.kt
Outdated
Show resolved
Hide resolved
franciscodr
reviewed
Sep 4, 2024
examples/src/main/kotlin/com/xebia/functional/xef/assistants/DSL.kt
Outdated
Show resolved
Hide resolved
franciscodr
previously approved these changes
Sep 4, 2024
…SL.kt Co-authored-by: Francisco Diaz <[email protected]>
franciscodr
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Metric capabilities by adding the possibility of adding counters. A new interface (
CounterMetric) and implementations forLogsMetricandOpenTelemtryhave been added to support this.The docker-compose files and configuration files for OpenTelemtry have also been moved inside the OpenTelemetry module.